Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(filter): add block-device-tag filter during manual claiming (#404) #486

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Sep 8, 2020

Enforce check on block device tag even for cases where block
devices are claimed with block device name.

cherry-pick #404

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

…enebs-archive#404)

Enforce check on block device tag even for cases where block 
devices are claimed with block device name. 

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-commenter
Copy link

Codecov Report

Merging #486 into v0.8.x will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.8.x     #486      +/-   ##
==========================================
- Coverage   40.53%   40.51%   -0.03%     
==========================================
  Files          71       71              
  Lines        3488     3490       +2     
==========================================
  Hits         1414     1414              
- Misses       1966     1968       +2     
  Partials      108      108              
Impacted Files Coverage Δ
pkg/select/blockdevice/select.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dc984...a5903fa. Read the comment docs.

@akhilerm akhilerm requested a review from kmova September 9, 2020 05:32
@kmova kmova merged commit 4af5d55 into openebs-archive:v0.8.x Sep 9, 2020
@akhilerm akhilerm deleted the cherry-404 branch December 13, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants