Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serde): fix serialization error for get/list nodes #786

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(serde): fix serialization error for get/list nodes #786

merged 1 commit into from
Mar 19, 2024

Conversation

sinhaashish
Copy link
Member

The below error was seen while getting the nodes in json format

[nix-shell:~/code/rust/mayastor-extensions]$ ./target/debug/kubectl-mayastor get node node-1-155678 -o json
thread 'main' panicked at dependencies/control-plane/control-plane/plugin/./src/resources/utils.rs:185:49:
called `Result::unwrap()` on an `Err` value: Error("can only flatten structs and maps (got a sequence)", line: 0, column: 0)

This PR fixes it.

@sinhaashish
fix(serde): fix serialization error for get nodes
bf099f5 
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
@sinhaashish sinhaashish changed the title fix(serde): fix serialization error for get nodes fix(serde): fix serialization error for get/list nodes Mar 19, 2024
@sinhaashish
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 919e1a1 into openebs:develop Mar 19, 2024
6 checks passed
@sinhaashish sinhaashish deleted the fix-serde-flattening branch March 19, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@abhilashshetty04 abhilashshetty04 abhilashshetty04 approved these changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

@blaisedias blaisedias Awaiting requested review from blaisedias

@rohan2794 rohan2794 Awaiting requested review from rohan2794

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sinhaashish @tiagolobocastro @Abhinandan-Purkait @abhilashshetty04