fix(getNode): return single element in get node #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
Abhinandan-Purkait
approved these changes
Mar 20, 2024
sinhaashish
requested review from
hrudaya21,
abhilashshetty04 and
chriswldenyer
hrudaya21
reviewed
Mar 20, 2024
hrudaya21
approved these changes
Mar 20, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
788: fix(getNode): return single element in get node r=sinhaashish a=sinhaashish
There was a regression issue in which `kubectl-mayastor get node node-1-155665 -ojson` was returning an array
```
[
{
"id": "node-1-155665",
"spec": {
"grpcEndpoint": "135.181.42.41:10124",
"id": "node-1-155665",
"node_nqn": "nqn.2019-05.io.openebs:node-name:node-1-155665"
},
"state": {
"grpcEndpoint": "135.181.42.41:10124",
"id": "node-1-155665",
"status": "Online",
"node_nqn": "nqn.2019-05.io.openebs:node-name:node-1-155665"
}
}
]
```
Earlier in 2.5 release it was returning a single element as below:
```
{
"id": "node-1-155665",
"spec": {
"grpcEndpoint": "135.181.42.41:10124",
"id": "node-1-155665",
"node_nqn": "nqn.2019-05.io.openebs:node-name:node-1-155665"
},
"state": {
"grpcEndpoint": "135.181.42.41:10124",
"id": "node-1-155665",
"status": "Online",
"node_nqn": "nqn.2019-05.io.openebs:node-name:node-1-155665"
}
}
```
This PR fixes that
Co-authored-by: sinhaashish <ashi.sinha.87@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression issue in which
kubectl-mayastor get node node-1-155665 -ojsonwas returning an arrayEarlier in 2.5 release it was returning a single element as below:
This PR fixes that