build: build static binaries with latest pkgs #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On nixpkgs bug where windows platform is set incorrectly for static packages: 281596 This can be worked around by using pkgStatic.pkgsCross rather than the other way around, or simply by replacing the package. As it happens, the tls build for windows doesn't need openssl, so we can remove it entirely and skip this issue altogether. On darwin, libiconv is failing to build, but also seems to not be required anymore, and so also removing it! Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih and
abhilashshetty04
tiagolobocastro
force-pushed
the
binaries-fix
branch
from
c5da6be to
e6a76a5
Compare
Add more interesting info when using wrong namespace, rather
simply stating service not found!
Previous error:
Service 'app=api-rest' not found
New error:
Service 'app=api-rest' not found on 'NameSpace(Some("mayastor"))'
Are you on the correct namespace?
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
binaries-fix
branch
from
e6a76a5 to
0a7448d
Compare
Abhinandan-Purkait
approved these changes
Nov 7, 2024
niladrih
approved these changes
Nov 7, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
567: build: build static binaries with latest pkgs r=tiagolobocastro a=tiagolobocastro On nixpkgs bug where windows platform is set incorrectly for static packages: 281596 This can be worked around by using pkgStatic.pkgsCross rather than the other way around, or simply by replacing the package. As it happens, the tls build for windows doesn't need openssl, so we can remove it entirely and skip this issue altogether. On darwin, libiconv is failing to build, but also seems to not be required anymore, and so also removing it! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
hmm weird build error.. let's try again |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nixpkgs bug where windows platform is set incorrectly for static
packages: 281596
This can be worked around by using pkgStatic.pkgsCross rather than
the other way around, or simply by replacing the package.
As it happens, the tls build for windows doesn't need openssl, so
we can remove it entirely and skip this issue altogether.
On darwin, libiconv is failing to build, but also seems to not be
required anymore, and so also removing it!