Add ServiceMonitor for device-LocalPV and fixes localpv workload dashboard #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xporter Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
Signed-off-by: Sahil Raja <sahilraja242@gmail.com> Dashboard refresh fix Signed-off-by: Sahil Raja <sahilraja242@gmail.com>
rajaSahil
force-pushed
the
Add-ServiceMonitor-DeviceLocalPV
branch
from
56b532c
to
0a8feb3
Compare
avishnu
reviewed
Jul 27, 2021
| @@ -141,6 +141,11 @@ helm install openebs-monitoring openebs-monitoring/monitoring --namespace openeb | |||
| | `serviceMonitors.lvm-LocalPV.endpoints.path` | HTTP path to scrape for metrics from lvm localPV node | `"/metrics"` | | |||
| | `serviceMonitors.lvm-LocalPV.selector` | Selector to select endpoints objects | `{matchLabels: {name: openebs-lvm-node}}` | | |||
| | `serviceMonitors.lvm-LocalPV.namespaceSelector` | Selector to select which namespaces the endpoints objects are discovered from | `[any: true]` | | |||
| | `serviceMonitors.device-LocalPV.enabled` | Enables monitoring of device localPV | `true` | | |||
| | `serviceMonitors.device-LocalPV.endpoints.ports` | Name of the service port device localPV node endpoint refers to | `"metrics"` | | |||
There was a problem hiding this comment.
Ok, seems we have used the same standard for other cas types as well.
Ab-hishek
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
/dev/sdb1 /dev/sdb2 ...) metricsFixes:
Issue:
Fix:
/mountwere getting selected.