usability: Handle Exceptions for no resources #103
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
- Coverage 67.66% 67.20% -0.46%
===========================================
Files 22 22
Lines 1633 1662 +29
===========================================
+ Hits 1105 1117 +12
- Misses 520 535 +15
- Partials 8 10 +2
Continue to review full report at Codecov.
|
pkg/blockdevice/blockdevice.go
Outdated
| } else { | ||
| // Show the output using cli-runtime | ||
| util.TablePrinter(util.BDTreeListColumnDefinations, rows, printers.PrintOptions{Wide: true}) | ||
| } |
There was a problem hiding this comment.
Dang, I'm positive golangCI-lint isn't running all the tools now, I'll will create a good-first-issue for the same.
What should have happened if CI was working optimally ?
The build should have ideally failed because we have added GolangCI-lint to our CI, I cannot recall the exact warning text but the functionality won't change even if the else bracket is removed, the tool which does it likely gosimple.
func awesome() {
....
if something {
return nil, err
} else {
return value, nil
}
} // end of functioncan get simplified to
func awesome() {
....
if something {
return nil, err
}
return value
} // end of function
pkg/util/error.go
Outdated
| @@ -40,3 +40,16 @@ func CheckErr(err error, handleErr func(string)) { | |||
| } | |||
| handleErr(err.Error()) | |||
| } | |||
|
|
|||
| // Handle Empty Table Error | |||
There was a problem hiding this comment.
| // Handle Empty Table Error | |
| // HandleEmptyTableError handles errors when a resource or set of resources aren't found |
This is a minor linting issue in golang, exported functions must be properly documented as such.
Ref: https://go.dev/blog/godoc
There was a problem hiding this comment.
Sounds great, Done
pkg/util/error.go
Outdated
| return fmt.Errorf("no %s found in your cluster", resource) | ||
| } else if ns != "" && casType != "" { | ||
| return fmt.Errorf("no %s %s found in %s namespace", casType, resource, ns) | ||
| } else if casType != "" { |
There was a problem hiding this comment.
Abhinandan has recently written a nice utility function which returns true for valid casTypes. Try to rebase your code against the current origin/develop and you'd likely see that in this package. Use that one for this condition check.
Signed-off-by: Abhishek-kumar09 <abhimait1909@gmail.com>
Signed-off-by: Abhishek-kumar09 <abhimait1909@gmail.com>
Signed-off-by: Abhishek-kumar09 <abhimait1909@gmail.com>
Abhishek-kumar09
force-pushed
the
excH
branch
from
ae51c8b to
acf45c5
Compare
Signed-off-by: Abhishek-kumar09 abhimait1909@gmail.com
Fixes #56
Now empty resource lists are handled by the openebsctl for storage, volumes and bd. They are handled separately on the basis of resourceType, casType and Namespaces.