revert!: remove legacy engines from the flow #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
force-pushed
the
deprecate_legacy
branch
from
6ec3781 to
b49ef67
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #157 +/- ##
============================================
- Coverage 69.92% 56.35% -13.58%
============================================
Files 26 15 -11
Lines 2148 834 -1314
============================================
- Hits 1502 470 -1032
+ Misses 630 362 -268
+ Partials 16 2 -14 ☔ View full report in Codecov by Sentry. |
|
Could you take a look at the failing CI? |
Abhinandan-Purkait
force-pushed
the
deprecate_legacy
branch
from
b49ef67 to
db0cbfd
Compare
I just updated all the github workflows. It should work now. |
Abhinandan-Purkait
force-pushed
the
deprecate_legacy
branch
2 times, most recently
from
e8ab473 to
b4944ea
Compare
tiagolobocastro
approved these changes
Mar 21, 2024
Abhinandan-Purkait
force-pushed
the
deprecate_legacy
branch
from
b4944ea to
d7f3075
Compare
Abhinandan-Purkait
changed the title
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
force-pushed
the
deprecate_legacy
branch
from
d7f3075 to
e33ce3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISABLED cSTOR and JIVA stem commands as these engines are to be made legacy and deprecated.
Changes