feat(velero): velero plugin for backup and restore for ZFS-LocalPV #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
force-pushed
the
backup
branch
2 times, most recently
from
335aefb
to
cc0daab
Compare
7 tasks
pawanpraka1
force-pushed
the
backup
branch
3 times, most recently
from
2a866a2
to
b3b1ed7
Compare
mynktl
reviewed
Aug 26, 2020
pawanpraka1
force-pushed
the
backup
branch
2 times, most recently
from
516b89d
to
feb78f1
Compare
mynktl
approved these changes
Aug 31, 2020
pkg/zfs/plugin/backup.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) createBackup(vol *apis.ZFSVolume, schdname, snapname string) (string, error) { | ||
|
|
There was a problem hiding this comment.
nit: unnecessary leading newline
pkg/zfs/plugin/restore.go
Outdated
| ) | ||
|
|
||
| func (p *Plugin) createVolume(pvname string, bkpname string, bkpZV *apis.ZFSVolume) (*apis.ZFSVolume, error) { | ||
|
|
pkg/zfs/plugin/restore.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) checkRestoreStatus(snapname string) { | ||
|
|
pkg/zfs/plugin/restore.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) restoreZFSVolume(pvname, bkpname string) (*apis.ZFSVolume, error) { | ||
|
|
pkg/zfs/plugin/restore.go
Outdated
|
|
||
| func (p *Plugin) checkRestoreStatus(snapname string) { | ||
|
|
||
| for true { |
There was a problem hiding this comment.
Suggested change
| for true { | |
| for { |
pkg/zfs/plugin/restore.go
Outdated
| var vol *apis.ZFSVolume = nil | ||
|
|
||
| if len (volList.Items) > 1 { | ||
| return nil, errors.Errorf("zfs: error can not have more than one source volume %s", pvname, bkpname) |
There was a problem hiding this comment.
missing indentifier for bkpname in Errorf.
7 tasks
A new provider(openebs.io/zfspv-blockstore) has been added to
support backup and restore for ZFS-LocalPV. We can use below
VolumeSnapshotLocation to backup/restore the data to/from the cloud.
```yaml
apiVersion: velero.io/v1
kind: VolumeSnapshotLocation
metadata:
name: default
namespace: velero
spec:
provider: openebs.io/zfspv-blockstore
config:
bucket: velero
prefix: zfs
namespace: openebs
provider: aws
region: minio
s3ForcePathStyle: "true"
s3Url: http://minio.velero.svc:9000
```
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
force-pushed
the
backup
branch
2 times, most recently
from
eb6658d
to
685b955
Compare
Signed-off-by: Pawan <pawan@mayadata.io>
mynktl
approved these changes
Sep 8, 2020
kmova
reviewed
Sep 8, 2020
| @@ -83,7 +83,7 @@ all: build | |||
| container: all | |||
| @echo ">> building container" | |||
| @cp Dockerfile _output/Dockerfile | |||
| docker build -t $(IMAGE):$(IMAGE_TAG) ${DBUILD_ARGS} -f _output/Dockerfile _output | |||
| @sudo docker build -t $(IMAGE):$(IMAGE_TAG) ${DBUILD_ARGS} -f _output/Dockerfile _output | |||
There was a problem hiding this comment.
Are these changes really required? sudo?
There was a problem hiding this comment.
yes, needed for docker.
kmova
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Adding backup and restore support for ZFS-LocalPV. The PR in the ZFS-LocalPV repo is here : openebs/zfs-localpv#162
What this PR does?:
A new provider(openebs.io/zfspv-blockstore) has been added to
support backup and restore for ZFS-LocalPV. We can use below
VolumeSnapshotLocation to backup/restore the data to/from the cloud.
Does this PR require any upgrade changes?:
no
If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:
test case: backup the full namespace, delete it, and restore it and verify the data.
Any additional information for your reviewer?:
I am using local repo in go mod as ZFS-LocalPV side changes are not merged. Will update that once changes are merged.
github.com/openebs/zfs-localpv => /home/pawan/Desktop/openebs/src/github.com/openebs/zfs-localpv
To Do:
There are few changes related to it in this PR, will support the full incremental backup and restore after PR #99
Checklist:
<type>(<scope>): <subject>