fix(restore): adding support to restore in an encrypted pool for ZFS-LocalPV #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LocalPV Encrypted pool does not allow the volume to be pre created for the restore purpose. Here changing the design to do the restore first and then create the ZFSVolume object which will bind the volume already created while doing restore. Signed-off-by: Pawan <pawan@mayadata.io>
mynktl
approved these changes
Mar 1, 2021
Signed-off-by: Pawan <pawan@mayadata.io>
mynktl
approved these changes
Mar 2, 2021
kmova
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: openebs/zfs-localpv#286
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
Encrypted pool does not allow the volume to be pre created for the
restore purpose.
What this PR does?:
Here changing the design to do the restore first
and then create the ZFSVolume object which will bind the volume
already created while doing restore.
Does this PR require any upgrade changes?:
Backward compatibility is maintained by ZFS-LocalPV.
Depends On
openebs/zfs-localpv#292