fix(topokey): changing topology key to unique name #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
added
bug
pawanpraka1
changed the title
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 23.57% 23.57%
=======================================
Files 14 14
Lines 475 475
=======================================
Hits 112 112
Misses 362 362
Partials 1 1 Continue to review full report at Codecov.
|
pawanpraka1
force-pushed
the
key
branch
2 times, most recently
from
4e5b80d
to
a873653
Compare
There are setups where nodename is different than the hostname. The driver uses the nodename and tries to set the "kubernetes.io/hostname" node label to the nodename. Which will fail if nodename is not same as hostname. Here, changing the key to unique name so that the driver can set that key as node label and also it can not modify/touch the existing node labels. Now onwards, the driver will use "openebs.io/nodename" key to set the PV node affinity. Old volumes will have "kubernetes.io/hostname" affinity, and they will also work as after the PR openebs#94, it supports all the node labels as topology key and all the nodes have "kubernetes.io/hostname" label set. So old volumes will work without any issue. Also for the same reason old stoarge classes which are using "kubernetes.io/hostname" as topology key, will work as that key is supported. This fixes the issue where the driver was trying to create the PV on the master node as master node is having "kubernetes.io/hostname" label, so it is also becoming a valid candidate for provisioning the PV. After changing the key to unique name, since the driver will not run on master node, so it will not set "openebs.io/nodename" label to this node hence this node will never become a valid candidate for the provisioning the volume. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #100
depends on :- #94
There are setups where nodename is different than the hostname.
The driver uses the nodename and tries to set the "kubernetes.io/hostname"
node label to the nodename. Which will fail if nodename is not same as
hostname. Here, changing the key to unique name so that the driver can set
that key as node label and also it can not modify/touch the existing node labels.
Now onwards, the driver will use "openebs.io/nodename" key to set the PV node affinity.
Old volumes will have "kubernetes.io/hostname" affinity, and they will also work as
after the PR #94, it supports all the node
labels as topology key and all the nodes have "kubernetes.io/hostname" label set. So
old volumes will work without any issue. Also for the same reason old stoarge classes
which are using "kubernetes.io/hostname" as topology key, will work as that key is supported.
Also Fixes : #47
This fixes the issue where the driver was trying to create the PV on the master node
as master node is having "kubernetes.io/hostname" label, so it is also becoming a valid
candidate for provisioning the PV. After changing the key to unique name, since the driver
will not run on master node, so it will not set "openebs.io/nodename" label to this node
hence this node will never become a valid candidate for the provisioning the volume.
Signed-off-by: Pawan pawan@mayadata.io