Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): Updated the doc for custom-topology support #122

Merged
merged 1 commit into from
May 20, 2020
Merged

chore(doc): Updated the doc for custom-topology support #122

merged 1 commit into from
May 20, 2020

Conversation

w3aman
Copy link
Contributor

@w3aman w3aman commented May 20, 2020

Signed-off-by: Aman Gupta aman.gupta@mayadata.io

What this PR does?

  • Updated the faq doc for custom-topology support by adding when restarting of zfs driver node agent is must, even though restart is recommended.

Signed-off-by: Aman Gupta <aman.gupta@mayadata.io>
@w3aman w3aman changed the title enhace(doc): Enhanced the doc for custom-topology support chore(doc): Enhanced the doc for custom-topology support May 20, 2020
@w3aman w3aman changed the title chore(doc): Enhanced the doc for custom-topology support chore(doc): Updated the doc for custom-topology support May 20, 2020
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@codecov-commenter
Copy link

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          14       14           
  Lines         489      489           
=======================================
  Hits          112      112           
  Misses        376      376           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f19a66...7884afb. Read the comment docs.

@pawanpraka1 pawanpraka1 merged commit 9118f56 into openebs:master May 20, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone Jun 4, 2020
@pawanpraka1 pawanpraka1 added the documentation Improvements or additions to documentation label Jun 4, 2020
vaniisgh pushed a commit to vaniisgh/zfs-localpv that referenced this pull request Jun 5, 2020
Signed-off-by: Aman Gupta <aman.gupta@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants