Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(print): removing unnecessary printer columns #128

Merged
merged 1 commit into from
May 21, 2020

Conversation

pawanpraka1
Copy link
Contributor

Creation time Stamp is not useful information as we already have the Age, Also volblocksize and Recordsize can not co-exist, feeling it is better to remove them(open for suggestion) as we can get the info from the storageclass.

Signed-off-by: Pawan pawan@mayadata.io

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          14       14           
  Lines         489      489           
=======================================
  Hits          112      112           
  Misses        376      376           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ef10c...1850bef. Read the comment docs.

@kmova kmova added this to the v0.8.0 milestone May 21, 2020
@kmova kmova merged commit d47ec3b into openebs:master May 21, 2020
@pawanpraka1 pawanpraka1 deleted the printer branch May 26, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants