Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readonly): honouring readonly flag. #137

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented May 27, 2020

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

Readonly flag does not come as mount option, it has
separate field to mention readonly flag. ZFS-LocalPV
driver should check that field and add "ro" as mountoption.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on

@pawanpraka1 pawanpraka1 added the bug Something isn't working. label May 27, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone May 27, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova May 27, 2020 08:45
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          14       14           
  Lines         489      489           
=======================================
  Hits          112      112           
  Misses        376      376           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47ec3b...aa8200b. Read the comment docs.

@kmova
Copy link
Member

kmova commented May 27, 2020

n_: misspelt feild in commit message

Readonly flag does not come as mount option, it has
separate field to mention readonly flag. ZFS-LocalPV
driver should check that field and add "ro" as mountoption.

Signed-off-by: Pawan <pawan@mayadata.io>
@pawanpraka1
Copy link
Contributor Author

@kmova corrected the typo. Thanks.

@kmova kmova merged commit 42ed7d8 into openebs:master May 27, 2020
@pawanpraka1 pawanpraka1 deleted the mntopt branch May 27, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants