feat(backup,restore): adding validation for backup and restore #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=========================================
- Coverage 9.82% 8.50% -1.32%
=========================================
Files 20 20
Lines 1171 1046 -125
=========================================
- Hits 115 89 -26
+ Misses 1055 956 -99
Partials 1 1
Continue to review full report at Codecov.
|
Added a schema validation for backup and restore CR. Also validating the server address in the backup/restore controller. Validating the server address as : ^([0-9]+.[0-9]+.[0-9]+.[0-9]+:[0-9]+)$ which is : <any number>.<any number>.<any number>.<any number>:<any number> Here we are validating just the format of the IP, not validating that IP should be correct which will be little more complex. In any case if IP is not correct, the zfs send will fail, so no need to do complex validation to validate the correct IP and port. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Sep 30, 2020
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Oct 12, 2020
Following PR added for changelog - openebs#211 - openebs#221 Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Oct 12, 2020
Following PR added for changelog - openebs#211 - openebs#221 Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
Added a schema validation for backup and restore CR. Also validating
the server address in the backup/restore controller.
What this PR does?:
Validating the server address as :
^([0-9]+.[0-9]+.[0-9]+.[0-9]+:[0-9]+)$
which is :
Here we are validating just the format of the IP, not validating that IP should be
correct which will be little more complex. In any case if IP is not correct,
the zfs send will fail, so no need to do complex validation to validate the
correct IP and port.
Does this PR require any upgrade changes?:
NA
Checklist:
<type>(<scope>): <subject>