-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor pkg/zfs/mount.go Remove MountInfo struct from api #225
Conversation
Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
Fixes openebs#142 Signed-off-by: Gagandeep Singh <codegagan@gmail.com> Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
Signed-off-by: Gagandeep Singh <codegagan@gmail.com> Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
73f3b52
to
a6bf049
Compare
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
======================================
Coverage 8.50% 8.50%
======================================
Files 20 20
Lines 1046 1046
======================================
Hits 89 89
Misses 956 956
Partials 1 1
Continue to review full report at Codecov.
|
@pawanpraka1 Request you to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @codegagan. Changes are fine. I have given few minor comments.
Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
@pawanpraka1 have implemented the suggestions. Also, if you considering this PR for merge, please add label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Thank you @codegagan for working on this PR. You can sign up for Hacktoberfest swag from MayaData by entering details here: https://github.com/mayadata-io/swag/issues/new/choose |
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?: Fixes #142
What this PR does?: refactors the code to move MountInfo struct from api files
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered:: make all
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>