Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pkg/zfs/mount.go Remove MountInfo struct from api #225

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

codegagan
Copy link
Contributor

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?: Fixes #142

What this PR does?: refactors the code to move MountInfo struct from api files

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered:: make all

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
Fixes openebs#142

Signed-off-by: Gagandeep Singh <codegagan@gmail.com>

Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
Signed-off-by: Gagandeep Singh <codegagan@gmail.com>

Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #225   +/-   ##
======================================
  Coverage    8.50%   8.50%           
======================================
  Files          20      20           
  Lines        1046    1046           
======================================
  Hits           89      89           
  Misses        956     956           
  Partials        1       1           
Impacted Files Coverage Δ
pkg/driver/agent.go 0.00% <0.00%> (ø)
pkg/usage/ping.go 41.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a155c...7137657. Read the comment docs.

@codegagan
Copy link
Contributor Author

@pawanpraka1 Request you to review.

Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @codegagan. Changes are fine. I have given few minor comments.

pkg/zfs/mount.go Outdated Show resolved Hide resolved
changelogs/unreleased/225-codegagan Outdated Show resolved Hide resolved
Signed-off-by: Gagandeep Singh <codegagan@gmail.com>
@codegagan
Copy link
Contributor Author

@pawanpraka1 have implemented the suggestions. Also, if you considering this PR for merge, please add label hacktoberfest-accepted.

Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pawanpraka1 pawanpraka1 merged commit 3da4f73 into openebs:master Oct 12, 2020
@pawanpraka1 pawanpraka1 added this to the v1.0.2 milestone Oct 12, 2020
@pawanpraka1
Copy link
Contributor

Thank you @codegagan for working on this PR.

You can sign up for Hacktoberfest swag from MayaData by entering details here: https://github.com/mayadata-io/swag/issues/new/choose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove MountInfo struct from the API file
3 participants