feat(kustomize): adding deployment via kustomize #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
force-pushed
the
kustomize
branch
from
aca00ea
to
2f8926f
Compare
|
Should not this be added in ci to test deployment via (-k) and then run all/some sanity tests ? |
|
Thanks @spencergilbert .
@codegagan will you be able to work on that part? |
prateekpandey14
approved these changes
Oct 29, 2020
deploy/yamls/kustomization.yaml
Outdated
| - zfssnapshot-crd.yaml | ||
| - zfsbackup-crd.yaml | ||
| - zfsrestore-crd.yaml | ||
| - zfs-driver.yaml |
There was a problem hiding this comment.
Do we need to update README with the command to use the kustomize based install using -k with kubectl apply ?
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #214
Signed-off-by: Pawan pawan@mayadata.io