feat(build): support for multi arch container image #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
force-pushed
the
multi-arch
branch
from
49940df
to
04da1a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
======================================
Coverage 8.50% 8.50%
======================================
Files 20 20
Lines 1046 1046
======================================
Hits 89 89
Misses 956 956
Partials 1 1 Continue to review full report at Codecov.
|
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
multi-arch
branch
from
04da1a7
to
73bc4d7
Compare
akhilerm
reviewed
Nov 5, 2020
akhilerm
reviewed
Nov 5, 2020
akhilerm
reviewed
Nov 5, 2020
akhilerm
reviewed
Nov 5, 2020
akhilerm
reviewed
Nov 9, 2020
akhilerm
reviewed
Nov 9, 2020
akhilerm
suggested changes
Nov 9, 2020
There was a problem hiding this comment.
@prateekpandey14 A change is required for the dockerhub credential env to make it consistent across all repositories.
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
multi-arch
branch
from
4bc3fb5
to
3c0c44c
Compare
|
@prateekpandey14 - can you get travis to push the zfs-driver-amd64 image? |
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
Done |
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
kmova
approved these changes
Nov 11, 2020
|
@prateekpandey14 can you raise a PR for the changelog? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io
Why is this PR required? What issue does it fix?:
PR add multi arch support for zfs-localpv container images
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>