Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): bump k8s csi to latest stable container images #271

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

shubham14bajpai
Copy link
Member

@shubham14bajpai shubham14bajpai commented Jan 5, 2021

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:

  • Bump k8s csi sidecar container image to latest stable releases minimum kubernetes version to support 1.17
  • Update the Snapshot specific CRDs to V1 version

The CRDs were taken from https://github.com/kubernetes-csi/external-snapshotter/tree/master/client/config/crd

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@shubham14bajpai shubham14bajpai requested review from prateekpandey14 and pawanpraka1 and removed request for prateekpandey14 January 5, 2021 12:44
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham14bajpai please add the role for the pods also (see https://github.com/openebs/lvm-localpv/pull/4/files#diff-4f244dfa96d1850f6e7316c74a68edfad485a629292e7e21011b48e0d43f6cd7R629). Latest csi-resizer needs that because of that test cases are failing.

@@ -546,7 +755,7 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: csi-snapshotter
image: quay.io/k8scsi/csi-snapshotter:v2.0.1
image: quay.io/k8scsi/csi-snapshotter:v3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use v4.0.0

@@ -558,21 +767,20 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: snapshot-controller
image: quay.io/k8scsi/snapshot-controller:v2.0.1
image: quay.io/k8scsi/snapshot-controller:v3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4.0.0?

@pawanpraka1
Copy link
Contributor

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jan 5, 2021
@pawanpraka1 pawanpraka1 added this to the 1.3.0 milestone Jan 5, 2021
@pawanpraka1 pawanpraka1 merged commit e0fbce8 into openebs:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants