feat(zfspv): remove finalizer that is owned by ZFS-LocalPV #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
added
enhancement
pawanpraka1
requested review from
kmova,
prateekpandey14,
akhilerm and
shubham14bajpai
akhilerm
reviewed
Apr 5, 2021
There was a problem hiding this comment.
@pawanpraka1 We need to make this same change in LVM localpv right?
akhilerm
reviewed
Apr 5, 2021
@akhilerm yes, it is good to have this change in LVM LocalPV repo also. |
akhilerm
reviewed
Apr 5, 2021
We set the Finalizer to nil while handling the delete event, instead, we should try to destroy the volume when there are no user finalizers set. User might have added his own finalizers and we should not try to destroy the volumes util those user finalizers are removed. Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #302
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
User might want to add extra protection on the ZFSVolume CR and wants to add finalizers on it. The current code does not allow the user to setup the user's finalizers on the ZFSVolume CR.
What this PR does?:
We set the Finalizer to nil while handling the delete event, instead,
we should try to destroy the volume when there are no user finalizers
set. User might have added his own finalizers and we should not try to destroy
the volumes util those user finalizers are removed.
Does this PR require any upgrade changes?:
PR handles upgrade scenario.