-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding topology support for zfspv #7
Conversation
Signed-off-by: Pawan <pawan@mayadata.io>
fd04c63
to
e014dd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 89.55% 89.55%
=======================================
Files 1 1
Lines 67 67
=======================================
Hits 60 60
Misses 7 7 Continue to review full report at Codecov.
|
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
…hment object Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
ZFSNodeKey string = "kubernetes.io/nodename" | ||
// ZFSTopologyKey is supported topology key for the zfs driver | ||
ZFSTopologyKey string = "kubernetes.io/hostname" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the topology be specified using node selectors ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you can specify both. But make sure both the setting are compliance with each other, otherwise pod will not be scheduled.
…brary also adding comments Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
We can provide the topology in storage class where the zfs pools are setup
The scheduler will take care of scheduling the application on the appropriate node.
Signed-off-by: Pawan pawan@mayadata.io