Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding topology support for zfspv #7

Merged
merged 10 commits into from
Nov 1, 2019
Merged

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Oct 15, 2019

We can provide the topology in storage class where the zfs pools are setup

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openebs-zfspv
allowVolumeExpansion: true
parameters:
  blocksize: "4k"
  compression: "on"
  dedup: "on"
  thinprovision: "yes"
  poolname: "zfspv-pool"
provisioner: zfs-localpv
volumeBindingMode: WaitForFirstConsumer
allowedTopologies:
- matchLabelExpressions:
  - key: kubernetes.io/hostname
    values:
      - gke-zfspv-pawan-default-pool-c8929518-cgd4
      - gke-zfspv-pawan-default-pool-c8929518-dxzc

The scheduler will take care of scheduling the application on the appropriate node.

Signed-off-by: Pawan pawan@mayadata.io

@pawanpraka1 pawanpraka1 changed the title [WIP] adding topology suppor for zfspv [WIP] adding topology support for zfspv Oct 15, 2019
Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files           1        1           
  Lines          67       67           
=======================================
  Hits           60       60           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0218dac...a2bacd3. Read the comment docs.

Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
…hment object

Signed-off-by: Pawan <pawan@mayadata.io>
@pawanpraka1 pawanpraka1 changed the title [WIP] adding topology support for zfspv adding topology support for zfspv Oct 29, 2019
Signed-off-by: Pawan <pawan@mayadata.io>
ZFSNodeKey string = "kubernetes.io/nodename"
// ZFSTopologyKey is supported topology key for the zfs driver
ZFSTopologyKey string = "kubernetes.io/hostname"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the topology be specified using node selectors ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you can specify both. But make sure both the setting are compliance with each other, otherwise pod will not be scheduled.

…brary also adding comments

Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
@kmova kmova merged commit d0e97cd into openebs:master Nov 1, 2019
@kmova kmova added this to the v0.1.0 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants