Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fixing resize flaky test case #71

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

We are comparing the desired size to the wrong field
because of that resize test is not executing correctly
and sometimes causing test case failure in travis.

The update call is failing sometimes while executing the zfs
property update test cases as for resize also the object
is getting modified. The test case will fail when object updation
happens between volume GET and UPDATE call while performing
zfs property update test case to set various properties on
ZFSVolume resource.

Signed-off-by: Pawan pawan@mayadata.io

@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Mar 26, 2020
@pawanpraka1 pawanpraka1 added this to the v0.6.0 milestone Mar 26, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova March 26, 2020 14:42
@pawanpraka1 pawanpraka1 force-pushed the resize branch 2 times, most recently from 78d481a to d2f0b8c Compare March 26, 2020 15:47
We are comparing the desired size to the wrong field
because of that resize test is not executing correctly
and sometimes causing test case failure in travis.

The update call is failing sometimes while executing the zfs
property update test cases as for resize also the object
is getting modified. The test case will fail when object updation
happens between volume GET and UPDATE call while performing
zfs property update test case to set various properties on
ZFSVolume resource.

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-io
Copy link

Codecov Report

Merging #71 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   23.57%   23.57%           
=======================================
  Files          14       14           
  Lines         475      475           
=======================================
  Hits          112      112           
  Misses        362      362           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed9ce5...31c3731. Read the comment docs.

@kmova kmova merged commit 80e4d06 into openebs:master Mar 26, 2020
@pawanpraka1 pawanpraka1 deleted the resize branch March 27, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants