Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

checkpoint: use edx-braze-client #169

Closed
wants to merge 1 commit into from

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Jun 23, 2022

  • Install edx-braze-client and create a new EdxBrazeClient class with the library client class as its base.
  • Use the new client for sending API-triggered campaign messages for the Enterprise Offer Usage email.
  • The send_offer_usage_email_via_braze task now takes a dict of {email: lms_user_id} instead of a simple list of email addresses as its first parameter.
  • Attempt to create_recipient with the lms user ID as the external ID for each email to which this message is sent.

Used by: #169

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production
    • test.in for test requirements
    • make upgrade && make requirements have been run to regenerate requirements
  • Version bumped

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub CI, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in ecommerce to upgrade dependencies (including ecommerce-worker)
    • This must be done after the version is visible in PyPi as make upgrade in ecommerce will look for the latest version in PyPi.
    • Note: the ecommerce-worker constraint in ecommerce must also be bumped to the latest version in PyPi.
  • Deploy ecommerce
  • Deploy ecomworker on GoCD.
    • While some functions in ecommerce-worker are run via ecommerce, others are handled by a standalone AMI and must be
      released via GoCD.

Comment on lines -18 to +23
filename = get_overrides_filename('ECOMMERCE_WORKER_CFG')
with open(filename) as f:
config_from_yaml = yaml.load(f)
# filename = get_overrides_filename('ECOMMERCE_WORKER_CFG')
# with open(filename) as f:
# config_from_yaml = yaml.load(f)

# Override base configuration with values from disk.
vars().update(config_from_yaml)
# # Override base configuration with values from disk.
# vars().update(config_from_yaml)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is local testing cruft, I'll add an OS variable flag check or something to make it easier to test without commenting code.

@iloveagent57
Copy link
Contributor Author

Moved to a fork PR: #170

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant