Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Aed/unrevert offer task #177

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Aed/unrevert offer task #177

merged 1 commit into from
Jul 5, 2022

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Jul 5, 2022

Adds a new task (while leave the deprecated/old task in place) to send enterprise offer usage emails via an API-triggered Braze campaign.

https://2u-internal.atlassian.net/browse/ENT-5940

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production
    • test.in for test requirements
    • make upgrade && make requirements have been run to regenerate requirements
  • Version bumped

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub CI, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in ecommerce to upgrade dependencies (including ecommerce-worker)
    • This must be done after the version is visible in PyPi as make upgrade in ecommerce will look for the latest version in PyPi.
    • Note: the ecommerce-worker constraint in ecommerce must also be bumped to the latest version in PyPi.
  • Deploy ecommerce
  • Deploy ecomworker on GoCD.
    • While some functions in ecommerce-worker are run via ecommerce, others are handled by a standalone AMI and must be
      released via GoCD.

@iloveagent57 iloveagent57 force-pushed the aed/unrevert-offer-task branch from 030569e to 593097b Compare July 5, 2022 14:00
@iloveagent57 iloveagent57 force-pushed the aed/unrevert-offer-task branch from 593097b to f82b3a8 Compare July 5, 2022 14:02
@iloveagent57 iloveagent57 merged commit fe4928d into master Jul 5, 2022
@iloveagent57 iloveagent57 deleted the aed/unrevert-offer-task branch July 5, 2022 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants