Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Commit

Permalink
fix: Docker multi-arch images push for linux/amd64, linux/arm64 (#4006)
Browse files Browse the repository at this point in the history
* fix: docker multi-arch image push

* fix: docker multi-arch images, code improvements

---------

Co-authored-by: Salman Nawaz <salman.nawaz@A006-01081.local>
  • Loading branch information
salman2013 and Salman Nawaz authored Sep 7, 2023
1 parent fa4ab4f commit f0e196f
Showing 1 changed file with 22 additions and 8 deletions.
30 changes: 22 additions & 8 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,39 @@ jobs:
console.log('Will use tag: ' + tagName);
return tagName;
result-encoding: string

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Set up QEMU
uses: docker/setup-qemu-action@v2

- name: Login to DockerHub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}

- name: Build and push Dev Docker image
uses: docker/build-push-action@v1
uses: docker/build-push-action@v4
with:
push: true
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
target: dev
repository: edxops/ecommerce-dev
tags: ${{ steps.get-tag-name.outputs.result }},${{ github.sha }}
tags: |
edxops/ecommerce-dev:${{ steps.get-tag-name.outputs.result }}
edxops/ecommerce-dev:${{ github.sha }}
platforms: linux/amd64,linux/arm64

# The current priority is to get the devstack off of Ansible based Images. Once that is done, we can come back to this part to get
# suitable images for smaller prod environments.
# - name: Build and push prod Docker image
# uses: docker/build-push-action@v1
# uses: docker/build-push-action@v4
# with:
# push: true
# username: ${{ secrets.DOCKERHUB_USERNAME }}
# password: ${{ secrets.DOCKERHUB_PASSWORD }}
# target: prod
# repository: edxops/ecommerce-prod
# tags: ${{ steps.get-tag-name.outputs.result }},${{ github.sha }}
# tags: |
# edxops/ecommerce-prod:${{ steps.get-tag-name.outputs.result }}
# edxops/ecommerce-prod:${{ github.sha }}
# platforms: linux/amd64,linux/arm64

0 comments on commit f0e196f

Please sign in to comment.