This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Replace rest_framework_swagger with drf_yasg #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
force-pushed
the
iamsobanjaved/replace-swagger
branch
from
6903b69 to
eef57b5
Compare
iamsobanjaved
force-pushed
the
iamsobanjaved/replace-swagger
branch
from
abe64a9 to
5f00f6b
Compare
iamsobanjaved
changed the title
|
@iamsobanjaved LGTM but I would like to mention one thing. From the documentation of |
iamsobanjaved
commented
Feb 21, 2022
| @@ -305,7 +305,7 @@ | |||
| 'crispy_forms', | |||
| 'solo', | |||
| 'social_django', | |||
| 'rest_framework_swagger', | |||
| 'drf_yasg', | |||
There was a problem hiding this comment.
@aht007 I have already added drf-yasg to INSTALLED_APPS here. This list (DJANGO_APPS) is the part of INSTALLED_APPS
There was a problem hiding this comment.
Oh Okay. I mistook this file for base.in
Jawayria
approved these changes
Feb 21, 2022
aht007
approved these changes
Feb 21, 2022
3 tasks
iamsobanjaved
added a commit
that referenced
this pull request
Mar 1, 2022
Co-authored-by: GonzaloRomero <gonzalo.romero@edunext.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #3539 as the author couldn't continue on that.
Upgrade issue: edx/upgrades#17
This PR is needed for Django 3.2 support.
Screenshots on devstack: