Skip to content
This repository has been archived by the owner on Feb 14, 2025. It is now read-only.

Replace pkg_resources with importlib.resources #46

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Replace pkg_resources with importlib.resources #46

merged 3 commits into from
Jan 17, 2025

Conversation

irtazaakram
Copy link
Contributor

farhan
farhan approved these changes Jan 13, 2025
View reviewed changes
Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested my self.
Trusting on the testing of @irtazaakram.

feanil
feanil reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're only testing this on Python 3.12, we should test on both 3.11 and 3.12

@irtazaakram irtazaakram requested a review from feanil January 16, 2025 06:39
@feanil feanil merged commit aacbfc2 into openedx-unsupported:master Jan 17, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feanil feanil feanil approved these changes

@farhan farhan farhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 3.8 & Add Support for Python 3.12 Move on from deprecated pkg_resources api
3 participants
@irtazaakram @feanil @farhan