Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only run the workflow on the upstream #66

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

e0d
Copy link
Contributor

@e0d e0d commented Sep 19, 2022

To facilitate the fork workflow, it is helpful to restrict some GitHub actions to run only on the upstream repository.

@e0d e0d requested a review from sarina September 19, 2022 13:32
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 50.98% // Head: 50.98% // No change to project coverage 👍

Coverage data is based on head (4a69d29) compared to base (6893518).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files           3        3           
  Lines          51       51           
=======================================
  Hits           26       26           
  Misses         25       25           
Flag Coverage Δ
unittests 50.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is something that should be cascaded to other repos, or just let other maintainers handle it?

@e0d
Copy link
Contributor Author

e0d commented Sep 19, 2022

Do you think this is something that should be cascaded to other repos, or just let other maintainers handle it?

I do, but I'm not sure what the best way to do that is yet. Ideas? I also want to make sure this works as expected.

@e0d e0d merged commit dee79d3 into openedx:master Sep 19, 2022
@e0d e0d deleted the e0d/restrict-workflow-to-upstream branch September 19, 2022 14:46
@sarina
Copy link
Contributor

sarina commented Sep 19, 2022

Once you've got this working, it would not be hard with the scripts I have to make this change ,make PRs, and tag maintainers to see if they want them. Although, most repos don't have official ones yet...

Another thought is to bring it up with maintainers as an idea they can adopt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants