Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize version number placement #118

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

aht007
Copy link
Member

@aht007 aht007 commented Nov 15, 2021

Issue: BOM-3041

Description:
Standardize Python version number placement in init.py

@aht007 aht007 requested a review from doctoryes November 15, 2021 13:38
Copy link

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a code perspective for all these pull requests @aht007 . I assume there is some external reason we chose the solution which places the version in a separate file, and I'm curious what that is. Or simply do more repos place the version in init.py than do not and this is less work?

@aht007
Copy link
Member Author

aht007 commented Nov 16, 2021

@connorhaugh Actually We are going to run a cleanup job for semantic release workflow and that workflow will need the current version of the package so we need it to be at some standard place for all repos so that we have a single source where we can look in each repo i.e. the 'init' file. Now for the question about why this approach, I will link a discussion here ARCH-BOM-DISCUSSION
Hope it clears any concerns from your side.

@aht007 aht007 merged commit d176ad2 into master Nov 17, 2021
@aht007 aht007 deleted the aht/BOM-3041-STANDARDIZE-VERSION-NUMBER branch November 17, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants