[BD-18] Standardize the make test targets #14
Conversation
|
Thanks for the pull request, @emZubair! I've created BLENDED-455 to keep track of it in Jira. More details are on the BD-18 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
emZubair
force-pushed
the
zubair/EDE-684_standarize_make_test_target
branch
3 times, most recently
from
c75051f
to
573c263
Compare
Makefile
Outdated
| @@ -1,6 +1,45 @@ | |||
| .PHONY: clean upgrade test quality | |||
There was a problem hiding this comment.
Add, all the targets you added below to this list.
Makefile
Outdated
| pip-sync requirements/base.txt requirements/constraints.txt requirements/test.txt requirements/travis.txt | ||
|
|
||
| quality-js: ## Run JavaScript linter | ||
| echo "Tool not configured for quality target" |
There was a problem hiding this comment.
If it's not setup for JS Quality, just remove the target so we can find repos with this issue in the future.
package.json
Outdated
| @@ -0,0 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
Don't make the empty test, if there are no tests to run here, that's useful information that something like this would hide. Go ahead and remove the package.json and package-lock.json files for now along with the test-js makefile target for now.
| quality-js: ## Run JavaScript linter | ||
| echo "Tool not configured for quality target" | ||
|
|
||
| quality-python: ## Run python linters |
There was a problem hiding this comment.
Update the travis file to use this target instead of having it's own copy of the same commands. Leaving it like it is now might result in drift if one of the targets is updated but not the other.
emZubair
force-pushed
the
zubair/EDE-684_standarize_make_test_target
branch
from
573c263
to
4f2d437
Compare
|
@feanil updated PR. |
emZubair
force-pushed
the
zubair/EDE-684_standarize_make_test_target
branch
from
4f2d437
to
0ff066f
Compare
Standardize the make test targets
Added target for test & clean
Packages added