Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move django rest swagger to drf-yasg #174

Closed

Conversation

NeOneSoft
Copy link
Contributor

This PR was created in order to remove django-rest-swagger package and use drf-yasg.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Oct 5, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @NeOneSoft! I've created OSPR-6110 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link

natabene commented Oct 6, 2021

@NeOneSoft Thanks so much! Is this for edx/upgrades#17 ? Is this ready for our review?

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #174 (5567cda) into master (a029fda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          412       412           
  Branches        47        47           
=========================================
  Hits           412       412           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a029fda...5567cda. Read the comment docs.

@NeOneSoft
Copy link
Contributor Author

Hi @natabene thank you for your response, yes it is for edx/upgrades#17 and its ready for review. Thanks a lot!!

@NeOneSoft NeOneSoft closed this Oct 12, 2021
@openedx-webhooks
Copy link

@NeOneSoft Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@NeOneSoft
Copy link
Contributor Author

This PR was closed on behalf of #176 in order to fix conflicting files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants