Skip to content

Commit

Permalink
fix: resolved PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
thezaeemaanwar committed Oct 11, 2023
1 parent fcaace3 commit 552b20d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lms/djangoapps/certificates/tests/test_webview_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@

FEATURES_WITH_CERTS_ENABLED = settings.FEATURES.copy()
FEATURES_WITH_CERTS_ENABLED['CERTIFICATES_HTML_VIEW'] = True
FEATURES_WITH_BADGES_ENABLED = FEATURES_WITH_CERTS_ENABLED.copy()
FEATURES_WITH_BADGES_ENABLED['ENABLE_OPENBADGES'] = True

FEATURES_WITH_CERTS_DISABLED = settings.FEATURES.copy()
FEATURES_WITH_CERTS_DISABLED['CERTIFICATES_HTML_VIEW'] = False
Expand Down Expand Up @@ -526,7 +524,6 @@ def test_rendering_course_organization_data(self):
self.assertContains(response, f'<title>test_organization {self.course.number} Certificate |')
self.assertContains(response, 'logo_test1.png')

@override_settings(FEATURES=FEATURES_WITH_BADGES_ENABLED)
@patch.dict("django.conf.settings.SOCIAL_SHARING_SETTINGS", {
"CERTIFICATE_TWITTER": True,
"CERTIFICATE_FACEBOOK": True,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,7 @@ describe('Program card View', () => {
expect(view.$el.find('.banner-image').attr('srcset')).toEqual('');
});

it('should render the subscription badge if subscription is active', () => {
expect(view.$('.subscription-badge .badge').html()?.trim()).toEqual('Subscribed');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,7 @@ describe('Program Details Header View', () => {
.toEqual(`${context.programData.authoring_organizations[0].name}'s logo`);
});

it('should render the subscription badge if subscription is active', () => {
expect(view.$('.meta-info .badge').html().trim()).toEqual('Subscribed');
});
});

0 comments on commit 552b20d

Please sign in to comment.