Add require_https to all is_safe_url calls #18328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyoungstrom
force-pushed
the
youngstrom/use-require-https-arg
branch
3 times, most recently
from
2ecc455 to
b8c51e1
Compare
michaelyoungstrom
force-pushed
the
youngstrom/use-require-https-arg
branch
from
b8c51e1 to
d6616c9
Compare
|
Your PR has finished running tests. |
doctoryes
approved these changes
Jun 7, 2018
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, June 11, 2018. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/PLAT-1828
sets
require_https=Truein allis_safe_urlcalls. This also required a few test changes, as a url beginning withhttpis no longer considered safe.