Fix pylint violations #2540
Merged
Fix pylint violations #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| Factory to generate leaf XModuleDescriptors. | ||
| """ | ||
| # pylint: disable=missing-docstring |
There was a problem hiding this comment.
Just checking - will this only disable the warning within this class?
If so, I'm fine with it, but if not, I'd prefer something that only disables the warnings in the places you intend.
There was a problem hiding this comment.
Yeah, it follows python's scoping (afaik).
There was a problem hiding this comment.
awesome thing to know, thanks
|
Address my comment however seems right, & once tests pass 👍 |
|
lgtm, thanks for cleaning this up |
|
Please merge as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.