Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a data migration to copy all course index data into MySQL #29144

Conversation

bradenmacdonald
Copy link
Contributor

Description

This is a follow up to #29058. This is the next step in moving part of the modulestore data (the course indexes / "active versions" table) from MongoDB to MySQL.

There are four steps planned in moving course index data to MySQL:

Supporting information

An earlier version of this migration failed due to a case insensitivity issue, which has since been fixed (in #29058).

Testing instructions

  1. Check out a master devstack. Make some changes to a course or two (maybe a library too).
  2. At http://localhost:18000/admin/split_modulestore_django/splitmodulestorecourseindex/ verify that any courses that you've modified are already copied into MySQL. Keep this tab open.
  3. Check out this PR and run LMS migrations
  4. Open http://localhost:18000/admin/split_modulestore_django/splitmodulestorecourseindex/ in a new tab, and compare to the prior version. Courses that were already present in MySQL should be unchanged, and all remaining courses from your devstack should now be listed there.

Deadline

None

Other information

See also the ADR for Mongo removal.

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 27, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! I've created OSPR-6180 to keep track of it in JIRA.

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@natabene
Copy link
Contributor

@bradenmacdonald Thank you for your contribution.

@ormsbee
Copy link
Contributor

ormsbee commented Oct 29, 2021

I'm going to be a bit busy today to watch this go out, but I'll merge on Monday morning.

@ormsbee
Copy link
Contributor

ormsbee commented Nov 1, 2021

@bradenmacdonald: FYI, there's a delay on this because I'm tracking down some flakiness added to the build that's related to the new table around active versions.

@bradenmacdonald
Copy link
Contributor Author

@ormsbee Hmm ok, let me know if I can help.

@bradenmacdonald
Copy link
Contributor Author

@ormsbee Just to confirm, it's a different issue than https://github.com/edx/edx-platform/pull/29109 right?

@ormsbee
Copy link
Contributor

ormsbee commented Nov 1, 2021

@bradenmacdonald: Yes, separate issue. I'll have a PR later this afternoon.

@natabene natabene removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 2, 2021
@ormsbee ormsbee merged commit 43bc683 into openedx:master Nov 3, 2021
@openedx-webhooks
Copy link

@ormsbee, @kdmccormick: thought you might like to know that bradenmacdonald merged this pull request.

@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants