Fix for bug Blades/BLD-152 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| 'youtube_streams': self.youtube_streams, | ||
| # render_template() converts Python None to string 'None'. Front-end expects an empty string, or | ||
| # a properly formatted string with YouTube IDs. We will return an empty string instead of 'None'. | ||
| 'youtube_streams': self.youtube_streams if self.youtube_streams else '', |
There was a problem hiding this comment.
Another alternative is to use self.youtube_streams = xmltree.get('youtube', '') in line 73.
|
@valera-rozuvan you should have one more person review the PR |
|
@jmclaus Can you please review? |
|
👍 , as soon as Carlos recommendations will be implemented |
|
@valera-rozuvan Only Python code, I shouldn't be a reviewer. @auraz is a better choice. |
|
👍 |
valera-rozuvan
added a commit
that referenced
this pull request
Jun 28, 2013
…bute Fix for bug Blades/BLD-152
e-kolpakov
referenced
this pull request
in open-craft/edx-platform
Nov 3, 2014
mattdrayer/api-org-migration: Moved api_manager data migration work to o...
Yasui-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
…urse closed course can cancel from dashboard(#244)
kawaguchi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 6, 2015
Merge pull request openedx#296 from Yasui-ks/develop/cypress/closedcourse
diegomillan
referenced
this pull request
in eduNEXT/edx-platform
Sep 14, 2016
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original problem (including description from https://edx-wiki.atlassian.net/browse/BLD-152 ):
If I remove the youtube attribute of the videoalpha player, I get an error from youtube rather than failing over to the other videos that I have provided.
The fix is basically making sure that either an empty string is passed or a correctly formated string of YouTube IDs.
@rocha Please review.