-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch from github/checkout @v2 to @V3 #30069
Conversation
Thanks for the pull request, @ghassanmas! I've created OSPR-6523 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Well to be fair, it turns out it wasn't related because v2/v3, rather it was some temp issue with microsoft packages hence actions/runner-images#5236 . |
Github checkout v3 is using node-16, so its expected to be more secure than v2. More info: https://github.com/actions/checkout/releases/tag/v3.0.0
0c2cb78
to
43a2669
Compare
This ready for review |
There was an issue with repo metadata generation in Microsoft packages and hence attempts to fetch the metadata would cause checksum issues. That being said the issue was resolved the same day. We are currently using checkout@v2 across openedx and just changing it here on platform would make it inconsistent and that too without any issues faced due to it. But I would like to have @awais786's views on it. |
Since the target issue for this change is not the concern anymore and we want to keep the behavior consistent across all the edx/openedx workflows so this change is unnecessary for now. We can close this for now and introduce this change later on if we face any issues due to @ghassanmas thanks for your efforts on this issue but we'll have to close this for now. |
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Since some tests fails possobly because v2 isn't supported ormaintained as v3.)
There seems to be an issue with github action v2, I have reported an issue on the action repo here But I think is better to use v3. If the tests passes now it means that has resolved it. Also the action repo itself start to use v3 for their workflow, henceAs it turns out and repoted below the test failing weren't related to checkout:
version rather something hast
Supporting information
Testing instructions
Just make sure to run this PR or its effect with self hosted runner (if there are?).
Since github/checkout@v3 only supprot runner :
If there are no self hosted runner then you can discard it