-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update event_bus_kafka and add event_bus_redis #32117
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
35a5466
to
cd6a101
Compare
@timmc-edx While running
I am not sure how to solve this without constraining request to 2.29.0. Please let me know if you have a better solution for this. |
I'd recommend running (I'm not sure if you've rebased recently, but it's also possible that this is already resolved on the master branch -- I remember there being a recent issue with urllib.) |
cd6a101
to
bd82b65
Compare
@timmc-edx Thanks! I did rebase and test yesterday but it was not fixed till then. But now it is fixed and I ran |
bd82b65
to
f09e16f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the commit/PR title (udpate instead of update) but otherwise looks ready to go!
(I'll merge on Monday morning.) |
f09e16f
to
d319655
Compare
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
EdX Release Notice: This PR has been deployed to the production environment. |
Description
Udpate event_bus_kafka and add event_bus_redis. Also, update event bus default to redis implementation in devstack.
Supporting information
Checklist: