Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update event_bus_kafka and add event_bus_redis #32117

Merged
merged 1 commit into from
May 15, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Apr 24, 2023

Description

Udpate event_bus_kafka and add event_bus_redis. Also, update event bus default to redis implementation in devstack.

Supporting information

Checklist:

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 24, 2023

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@navinkarkera navinkarkera changed the title feat: remove hard dependency on event bus kafka feat: remove dependency on event bus kafka Apr 24, 2023
@navinkarkera navinkarkera force-pushed the navin/redis-event-bus branch from 35a5466 to cd6a101 Compare May 2, 2023 07:19
requirements/edx/base.in Outdated Show resolved Hide resolved
@navinkarkera navinkarkera changed the title feat: remove dependency on event bus kafka feat: udpate event_bus_kafka and add event_bus_redis May 2, 2023
@navinkarkera
Copy link
Contributor Author

@timmc-edx While running make upgrade after upgrading kafka and adding redis event bus, I am getting below error which is not related to any of them but to edx-enterprise and py2neo.

  found candidate uritemplate==4.1.1 (constraint was >=3.0.0)
Using legacy resolver. Consider using backtracking resolver with `--resolver=backtracking`.
Could not find a version that matches urllib3<1.27,<2,<3,==2.0.2,>=1.21.1 (from -r requirements/edx/paver.txt (line 51))
Tried: 0.3, 1.0, 1.0.1, 1.0.2, 1.1, 1.2, 1.2.1, 1.2.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.7.1, 1.8, 1.8.2, 1.8.3, 1.9, 1.9.1, 1.10, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.11, 1.11, 1.12, 1.12, 1.13, 1.13, 1.13.1, 1.13.1, 1.14, 1.14, 1.15, 1.15, 1.15.1, 1.15.1, 1.16, 1.16, 1.17, 1.17, 1.
18, 1.18, 1.18.1, 1.18.1, 1.19, 1.19, 1.19.1, 1.19.1, 1.20, 1.20, 1.21, 1.21, 1.21.1, 1.21.1, 1.22, 1.22, 1.23, 1.23, 1.24, 1.24, 1.24.1, 1.24.1, 1.24.2, 1.24.2, 1.24.3, 1.24.3, 1.25, 1.25, 1.25.1, 1.25.1, 1.25.2, 1.25.2, 1.25.3, 1.25.3, 1.25.4, 1.25.4, 1.25.5, 1.25.5, 1.25
.6, 1.25.6, 1.25.7, 1.25.7, 1.25.8, 1.25.8, 1.25.9, 1.25.9, 1.25.10, 1.25.10, 1.25.11, 1.25.11, 1.26.0, 1.26.0, 1.26.1, 1.26.1, 1.26.2, 1.26.2, 1.26.3, 1.26.3, 1.26.4, 1.26.4, 1.26.5, 1.26.5, 1.26.6, 1.26.6, 1.26.7, 1.26.7, 1.26.8, 1.26.8, 1.26.9, 1.26.9, 1.26.10, 1.26.10, 
1.26.11, 1.26.11, 1.26.12, 1.26.12, 1.26.13, 1.26.13, 1.26.14, 1.26.14, 1.26.15, 1.26.15, 2.0.0, 2.0.0, 2.0.1, 2.0.1, 2.0.2, 2.0.2
Skipped pre-versions: 2.0.0a1, 2.0.0a1, 2.0.0a2, 2.0.0a2, 2.0.0a3, 2.0.0a3, 2.0.0a4, 2.0.0a4
There are incompatible versions in the resolved dependencies:
  urllib3==2.0.2 (from -r requirements/edx/paver.txt (line 51))
  urllib3 (from py2neo==2021.2.3->-r requirements/edx/base.in (line 144))
  urllib3<3,>=1.21.1 (from requests==2.30.0->-r requirements/edx/paver.txt (line 40))
  urllib3<2,>=1.21.1 (from elasticsearch==7.13.4->-c requirements/edx/../common_constraints.txt (line 32))
  urllib3<1.27,>=1.21.1 (from snowflake-connector-python==3.0.3->edx-enterprise==3.62.6->-r requirements/edx/base.in (line 87))

I am not sure how to solve this without constraining request to 2.29.0. Please let me know if you have a better solution for this.

@timmc-edx
Copy link
Contributor

I'd recommend running make compile-requirements instead. It's only available in a couple of our repos, but it ensures a more minimal set of changes rather than trying to upgrade every package.

(I'm not sure if you've rebased recently, but it's also possible that this is already resolved on the master branch -- I remember there being a recent issue with urllib.)

@navinkarkera navinkarkera force-pushed the navin/redis-event-bus branch from cd6a101 to bd82b65 Compare May 12, 2023 03:10
@navinkarkera
Copy link
Contributor Author

@timmc-edx Thanks! I did rebase and test yesterday but it was not fixed till then. But now it is fixed and I ran make compile-requirements instead of upgrade. This is ready for your review.

@navinkarkera navinkarkera marked this pull request as ready for review May 12, 2023 03:12
@navinkarkera navinkarkera requested a review from timmc-edx May 12, 2023 03:12
@navinkarkera navinkarkera force-pushed the navin/redis-event-bus branch from bd82b65 to f09e16f Compare May 12, 2023 13:24
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the commit/PR title (udpate instead of update) but otherwise looks ready to go!

@timmc-edx
Copy link
Contributor

(I'll merge on Monday morning.)

@navinkarkera navinkarkera changed the title feat: udpate event_bus_kafka and add event_bus_redis feat: update event_bus_kafka and add event_bus_redis May 15, 2023
@navinkarkera navinkarkera force-pushed the navin/redis-event-bus branch from f09e16f to d319655 Compare May 15, 2023 03:28
@timmc-edx timmc-edx merged commit ab83771 into openedx:master May 15, 2023
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@navinkarkera navinkarkera deleted the navin/redis-event-bus branch May 15, 2023 13:41
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants