-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: due date reminder #32826
base: master
Are you sure you want to change the base?
feat: due date reminder #32826
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
5593a64
to
bfd2e01
Compare
bfd2e01
to
fd4f0e6
Compare
d414237
to
0fd30c9
Compare
openedx/core/djangoapps/schedules/management/commands/send_course_due_date_reminders.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/send_course_due_date_reminders.py
Show resolved
Hide resolved
7884b4f
to
70fc549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navinkarkera, this works great! I'll convert this to a draft for now so we can test it on Staging.
89f92d1
to
c21378b
Compare
fc17ad0
to
5816a03
Compare
Adds a command to send reminder emails for self-paced courses with relative due dates.
5816a03
to
8f213ac
Compare
Sandbox destroy request received. |
Hi @navinkarkera and @Agrendalath! Just checking to see if this is still in progress? |
@mphilbrick211, this has already been implemented, but we must pass it through the client's QA. This should be resumed around March. It would be great to get your product review in the meantime. |
Thanks @Agrendalath . With the info provided here, this seems like a nice addition. I'd like to be able to see the whole workflow in action, from adding the due date in the graded subsection to creating and sending an email that pulls the query. Is it possible to play with it in your sandbox? |
@jmakowski1123, thanks for checking. Of course, we will create a sandbox once we move forward with the implementation after the initial QA. We're discussing adding more features, like opting out of these emails for individual courses. |
Ok, let's keep this on hold then until it becomes a priority, and then can continue reviewing once you have specs for the new features. |
Description
This PR adds a command to send reminder emails for self-paced courses with relative due dates enabled. The command takes in a argument
due-in
which allows us to send reminders for subsections due within specified number of days.Testing instructions
studio.custom_relative_dates
to allow adding custom relative dates to graded subsections.make {lms,cms}-up
.make lms-migrate
to add enqueue and deliver columns for new schedule.localhost:18000
site and enable all flags.self-paced
(for this you might need to update start_date to some date in future and revert back).edx
user and enroll in the demo course.make lms-shell
and run below command, play with date and due-in parameter and see the output. It should print email with subsections having due date falling within the days passed viadue-in
parameter.SelfPacedRelativeDateConfig
is enabled and if course pacing is set toself-paced
.Due in
field for a graded subsection:Example output:
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Doubts:
Private-ref: BB-7407