Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix middleware get_response parameter deprecation warning #33067

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: fix middleware get_response parameter deprecation warning #33067

merged 1 commit into from
Aug 22, 2023

Conversation

UsamaSadiq
Copy link
Member

Description

UsamaSadiq
UsamaSadiq commented Aug 21, 2023
View reviewed changes
Copy link
Member Author

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super() doesn't take any keyword arguments.

openedx/core/djangoapps/cache_toolbox/middleware.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/cors_csrf/middleware.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/cors_csrf/middleware.py Outdated Show resolved Hide resolved
UsamaSadiq
UsamaSadiq commented Aug 21, 2023
View reviewed changes
Copy link
Member Author

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super() can't have function as argument.

openedx/core/djangoapps/cache_toolbox/middleware.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/cors_csrf/middleware.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/cors_csrf/middleware.py Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq force-pushed the fix-middleware-get-response-deprecation-warning branch from ea0a900 to c602edd Compare August 21, 2023 12:37
@UsamaSadiq UsamaSadiq marked this pull request as ready for review August 21, 2023 12:40
@UsamaSadiq UsamaSadiq force-pushed the fix-middleware-get-response-deprecation-warning branch from 7bf9661 to e6f7a11 Compare August 22, 2023 07:49
@UsamaSadiq UsamaSadiq merged commit 7710e60 into master Aug 22, 2023
@UsamaSadiq UsamaSadiq deleted the fix-middleware-get-response-deprecation-warning branch August 22, 2023 10:52
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

mehedikhan72 pushed a commit to mehedikhan72/edx-platform that referenced this pull request Aug 24, 2023
@UsamaSadiq @mehedikhan72
fix: fix middleware get_response parameter deprecation warning (opene…
af26e0d 
…dx#33067)
@irtazaakram irtazaakram mentioned this pull request Aug 25, 2023
Merged
@OmarIthawi OmarIthawi mentioned this pull request Jul 24, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irtazaakram irtazaakram irtazaakram approved these changes

@awais786 awais786 awais786 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UsamaSadiq @edx-pipeline-bot @awais786 @irtazaakram