Fixed accessibility labels are not always created in problems.

[waheedahmed]

In multiple part question the label did not show up as a "label" field for every second part. e.g.(only showing for 1st, 3rd, 5th...)

JIRA: STUD-1524

[waheedahmed]

@adampalay @davestgermain @andy-armstrong

[andy-armstrong]

I'm nervous about this, so can you explain how your change is working. The code you removed said it was there to handle problems with multiple questions, and then it looks like you have also removed the test which verified that case. I wouldn't expect to see any tests removed as part of this change.

Also, please add a new test for the problem you have fixed.

[waheedahmed]

@andy-armstrong the code which i removed actually creating this bug and the tests are written for the scenario which it was creating, so i fixed them too.

[davestgermain]

@waheedahmed it looks like the test you removed covers the case where somebody has multiple questions but decided only to put the label on the first question. I believe that removing the code in edit.coffee will have the effect of assigning the label to the wrong question, in this case. Is that true?

[waheedahmed]

@davestgermain @andy-armstrong does it looks fine now?

[davestgermain]

that edit.coffee function is probably in need of a rethink, but for now 👍

[waheedahmed]

@andy-armstrong waiting for thumbs up.

[andy-armstrong]

👍 Sorry to be slow getting back to you, and thanks for addressing my concerns.