feat: add has_course_author_access to CourseHomeMetadataView response [BB-9082] #35313
Conversation
|
Thanks for the pull request, @0x29a! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
the
needs reviewer assigned
0x29a
force-pushed
the
0x29a/BB-9082/add-roles-to-course-metadata
branch
2 times, most recently
from
99ae09f
to
a961d8f
Compare
0x29a
changed the title
0x29a
force-pushed
the
0x29a/BB-9082/add-roles-to-course-metadata
branch
from
a961d8f
to
d75051e
Compare
| @@ -139,6 +140,7 @@ def get(self, request, *args, **kwargs): | |||
| 'can_view_certificate': certificates_viewable_for_course(course), | |||
| 'course_modes': course_modes, | |||
| 'is_new_discussion_sidebar_view_enabled': new_discussion_sidebar_view_is_enabled(course_key), | |||
| 'has_course_author_access': has_course_author_access(request.user, course_key, 'cms'), | |||
There was a problem hiding this comment.
I think we should leave a comment here explaining why we had to pass cms as the service variant here, even though the API might have been called from the LMS
There was a problem hiding this comment.
Perhaps add some tests here to make sure the correct value for has_course_author_access for full staff/limited staff roles
There was a problem hiding this comment.
@0x29a Left a couple of small comments, but otherwise the changes looks good.
👍
- I tested this: Tested in local devstack
- I read through the code
itsjeyd
added
product review
|
OSPR management note: User-facing change, so will likely need product approval before we can move forward with engineering review and merge. Marking as blocked for now. |
Description
Adds
has_course_author_accessboolean toCourseHomeMetadataView. Currently it's used to control visibility of the "View as Staff" button here: openedx/frontend-app-learning#1436Testing
Open any unit in
frontend-app-learning, openNetworktab in your browser console, and search formetathere. There will be a single request, and its JSON response should containhas_course_author_accesskey. It should beFalsefor all users that don't have access to Studio, especially those having the "Limited Staff" course team role.