Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reapply forum v2 changes #36002

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat: reapply forum v2 changes #36002

merged 3 commits into from
Dec 12, 2024

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Dec 10, 2024

Description

Restore the following PR: #35671
Include the following feature: #35995

Supporting information

See discussion here: openedx/forum#137 (comment)
FYI @ormsbee

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 10, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@regisb regisb mentioned this pull request Dec 10, 2024
Open
@regisb regisb force-pushed the regisb/forumv2 branch 2 times, most recently from 4db17f3 to 5ad0f1f Compare December 10, 2024 13:22
@regisb
Copy link
Contributor Author

regisb commented Dec 10, 2024 •
edited
Loading

FYI CI is broken, here is the fix: #36003

EDIT: CI was not broken, it's just that I was compiling requirements with python 3.11.1, and I should have used 3.11.10. The issue comes from that line in redis-py: https://github.com/redis/redis-py/blob/8f2276e14d98b20cd9fc7b4a9e4e084fe9c74609/setup.py#L38

@regisb
feat: Reapply "Integrate Forum V2 into edx-platform"
6707fab 
This reverts commit 818aa34.
@regisb
feat: make it possible to globally disable forum v2 with setting
5520613 
We introduce a setting that allows us to bypass any course waffle flag
check. The advantage of such a setting is that we don't need to find the
course ID: in some cases, we might not have access to the course ID, and
we need to look for it... in forum v2.

See discussion here: openedx/forum#137
@regisb
Copy link
Contributor Author

regisb commented Dec 10, 2024 •
edited
Loading

Let's wait until we've merged openedx/forum#139 Then we can bump forum to 0.1.5 here.

EDIT: done: https://pypi.org/project/openedx-forum/ This should be ready to merge. FYI @ormsbee

@regisb
chore: bump openedx-forum to 0.1.5
c7c430b 
This should fix an issue with index creation on edX.org.
@AhtishamShahid AhtishamShahid merged commit 065adf3 into openedx:master Dec 12, 2024
50 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhtishamShahid AhtishamShahid AhtishamShahid approved these changes

@ormsbee ormsbee ormsbee approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@regisb @openedx-webhooks @edx-pipeline-bot @ormsbee @AhtishamShahid