Reinstate problem_check event as Problem Checked event #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #Logger.log 'problem_check', @answers | ||
| # Calling check from check_fd will result in firing the 'problem_check' event twice, | ||
| # since it is also called in the check function. | ||
| # Logger.log 'problem_check', @answers |
|
From a technical standpoint, this looks good. 😎 |
|
Thank you @dianakhuang. @shnayder, are you okay with this now? |
|
Yup, looks good. |
rlucioni
added a commit
that referenced
this pull request
Jul 16, 2013
Reinstate problem_check event as Problem Checked event
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Kimth/generic coderesponse
Kelketek
referenced
this pull request
in open-craft/edx-platform
Mar 31, 2015
mattdrayer/MCKIN-3046-2: False status for zero grades
xavierchan
pushed a commit
to xavierchan/edx-platform-1
that referenced
this pull request
May 20, 2019
增加了类modefi-loading-animation，修改加载图片样式
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change which will allow us to continue tracking problem check events. We lost this ability after deciding to return the Logger to its original behavior. @shnayder and @dianakhuang, please review?