Don't break up i18n string #6225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,9 @@ <h1 class="page-header">${_("Studio Account Activation")}</h1> | |||
| <h1 class="title">${_('Your account activation is invalid')}</h1> | |||
| <div class="copy"> | |||
| <p>${_("We're sorry. Something went wrong with your activation. Check to make sure the URL you went to was correct — e-mail programs will sometimes split it into two lines.")}</p> | |||
There was a problem hiding this comment.
Is use of the — required here?
|
Thanks for catching. Sorry for catching more. 👍 once comments addressed. |
singingwolfboy
force-pushed
the
studio-i18n-improvements
branch
from
fc33632 to
71a74c4
Compare
|
I did not check out and test this, but the change looks reasonable. 👍 |
singingwolfboy
added a commit
that referenced
this pull request
Dec 12, 2014
Don't break up i18n string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.