Dhm/editable metadata #844
Conversation
|
My upgrade to xblock 0.3 is significantly larger than this PR, so I'd like to merge it first. I think it'll be easier to figure out the conflicts and changes needed on this change than in the other. |
| self._fields = initial_values or {} | ||
|
|
||
| @property | ||
| def inherited_settings(self): |
There was a problem hiding this comment.
Why is this a property, and not just an attribute on the class? The getter and setter don't do anything except get and set.
There was a problem hiding this comment.
Over application of getter/setter pattern. Sorry.
|
Rebased on @cpennington's PR and rewrote history some to consolidate changes. Passes all tests locally. |
| # TODO: Once mixins are defined per-application, rather than per-runtime, | ||
| # this should use a cms mixed-in class. (cpennington) | ||
| if hasattr(component_class, 'display_name'): | ||
| display_name = component_class.display_name.default or 'Blank' |
There was a problem hiding this comment.
Why not use getattr with 'blank' as the default value?
There was a problem hiding this comment.
Actually... Can't do that, because we're looking for the display_name attribute, and then getting the .default from it. getattr only supports a single level of lookup.
| self.end_page == other.end_page and | ||
| # could actually compare structures and ignore whitespace but this seemed easiest if not quite sound | ||
| etree.tostring(self.table_of_contents) == etree.tostring(other.table_of_contents)) | ||
|
|
There was a problem hiding this comment.
Already implemented in my changes. Don't need 2 copies of the method.
|
😵 🐴 : 👍 |
Include mixins in advanced component class loading and preview modules
refactoring of platform to xblock 0.3 w/ refactoring of inheritance in the platform to a consistent representation.
Revive account settings fork for uneditable fields
@cpennington I'm sure this collides w/ your PR. Can we get this in first? Please review
@cahrens @chrisndodge @singingwolfboy can one of your review it from the studio perspective?
This PR has xblock compute inherited fields via an override of the default fn. It standardizes the representation of inherited fields through a new KVS called InheritanceKVS and has all of the other ones derive from this or (in the case of LmsKVS) delegate to it when a default is needed.
It replaces all simple dict model data containers w/ real xblock ones esp in the test code (already that way in prod code).
the 2 'x' commits were due to typos and not having lms kvs delegate.