feat!: remove deprecated signal parameter from consumer (#171)

openedx · May 17, 2023 · e466e21 · e466e21
1 parent be6c4a8
commit e466e21
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 10 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -14,6 +14,12 @@ Change Log
 Unreleased
 **********
 
+[5.0.0] - 2023-05-17
+********************
+Changed
+=======
+* **BREAKING CHANGE**: Removed deprecated ``signal`` argument from consumer initialization
+
 [4.0.1] - 2023-05-10
 ********************
 Fixed

diff --git a/edx_event_bus_kafka/__init__.py b/edx_event_bus_kafka/__init__.py
@@ -9,4 +9,4 @@
 from edx_event_bus_kafka.internal.consumer import KafkaEventConsumer
 from edx_event_bus_kafka.internal.producer import KafkaEventProducer, create_producer
 
-__version__ = '4.0.1'
+__version__ = '5.0.0'
diff --git a/edx_event_bus_kafka/internal/consumer.py b/edx_event_bus_kafka/internal/consumer.py
@@ -112,13 +112,12 @@ class KafkaEventConsumer(EventBusConsumer):
     Attributes:
         topic: Topic to consume (without environment prefix).
         group_id: Consumer group id.
-        signal: DEPRECATED Type of signal to emit from consumed messages. Will be removed in a future version
         consumer: Actual kafka consumer instance.
         offset_time: The timestamp (in ISO format) that we would like to reset the consumers to. If this is used, the
             consumers will only reset the offsets of the topic but will not actually consume and process any messages.
     """
 
-    def __init__(self, topic, group_id, signal=None, offset_time=None):  # pylint: disable=unused-argument
+    def __init__(self, topic, group_id, offset_time=None):
         if confluent_kafka is None:  # pragma: no cover
             raise Exception('Library confluent-kafka not available. Cannot create event consumer.')
 

diff --git a/requirements/base.in b/requirements/base.in
@@ -2,7 +2,7 @@
 -c constraints.txt
 
 Django                                  # Web application framework
-# openedx-events 7.1.0 introduces consumer api and consume_events command
-openedx-events>=7.1.0                   # Events API
+# openedx-events 8.0.0 removes an argument from consumer initialization
+openedx-events>=8.0.0                   # Events API
 edx_django_utils
 edx_toggles
diff --git a/requirements/base.txt b/requirements/base.txt
@@ -48,7 +48,7 @@ markupsafe==2.1.2
     # via jinja2
 newrelic==8.8.0
     # via edx-django-utils
-openedx-events==7.2.0
+openedx-events==8.0.0
     # via -r requirements/base.in
 pbr==5.11.1
     # via stevedore

diff --git a/requirements/dev.txt b/requirements/dev.txt
@@ -202,7 +202,7 @@ newrelic==8.8.0
     # via
     #   -r requirements/quality.txt
     #   edx-django-utils
-openedx-events==7.2.0
+openedx-events==8.0.0
     # via -r requirements/quality.txt
 packaging==23.1
     # via

diff --git a/requirements/doc.txt b/requirements/doc.txt
@@ -152,7 +152,7 @@ newrelic==8.8.0
     # via
     #   -r requirements/test.txt
     #   edx-django-utils
-openedx-events==7.2.0
+openedx-events==8.0.0
     # via -r requirements/test.txt
 packaging==23.1
     # via

diff --git a/requirements/quality.txt b/requirements/quality.txt
@@ -150,7 +150,7 @@ newrelic==8.8.0
     # via
     #   -r requirements/test.txt
     #   edx-django-utils
-openedx-events==7.2.0
+openedx-events==8.0.0
     # via -r requirements/test.txt
 packaging==23.1
     # via

diff --git a/requirements/test.txt b/requirements/test.txt
@@ -88,7 +88,7 @@ newrelic==8.8.0
     # via
     #   -r requirements/base.txt
     #   edx-django-utils
-openedx-events==7.2.0
+openedx-events==8.0.0
     # via -r requirements/base.txt
 packaging==23.1
     # via pytest