fix: pass offsets to partitions as milliseconds instead of seconds #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2023 13:14
timmc-edx
reviewed
Jan 6, 2023
| # Get the offset from the epoch in seconds. | ||
| offset_timestamp_s = int(offset_timestamp.timestamp()) | ||
| # Get the offset from the epoch (Kafka expects offsets in milliseconds for offsets_for_times, see | ||
| # https://kafka-python.readthedocs.io/en/master/apidoc/KafkaConsumer.html#kafka.KafkaConsumer.offsets_for_times) |
There was a problem hiding this comment.
Might be misleading to link to the kafka-python library's docs here, since we're not using it.
There was a problem hiding this comment.
Good catch. I'll see if I can find it in the library we're actually using.
There was a problem hiding this comment.
As far as I can tell it's undocumented, both for confluent-kafka and the underlying librdkafka. I have a PR open to add a note about it in the latter.
timmc-edx
reviewed
Jan 6, 2023
timmc-edx
reviewed
Jan 6, 2023
timmc-edx
approved these changes
Jan 6, 2023
Co-authored-by: Tim McCormack <tmccormack@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka partitions expect time offsets to be in milliseconds instead of seconds, so multiply the timestamp by 1000 before setting it on the partition.
Tested locally against the dev cluster.
Merge checklist:
Check off if complete or not applicable: