fix: Use non-blocking poll after production; allow flush for testing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe a nullary call to poll uses a default timeout of -1 (wait indefinitely), but we really just want to make sure that pending callbacks are triggered for the acks that have been buffered in the background, from previous events. poll(0) will not block if the buffer is empty. For testing we need to call flush(-1), so add sync=True as an option. Documentation for `rd_kafka_poll`: https://github.com/edenhill/librdkafka/blob/4faeb8132521da70b6bcde14423a14eb7ed5c55e/src/rdkafka.h#L3079
dianakhuang
approved these changes
Jul 27, 2022
whuang1202
pushed a commit
that referenced
this pull request
Aug 10, 2022
…12) I believe a nullary call to poll uses a default timeout of -1 (wait indefinitely), but we really just want to make sure that pending callbacks are triggered for the acks that have been buffered in the background, from previous events. poll(0) will not block if the buffer is empty. For testing we need to call flush(-1), so add sync=True as an option. Documentation for `rd_kafka_poll`: https://github.com/edenhill/librdkafka/blob/4faeb8132521da70b6bcde14423a14eb7ed5c55e/src/rdkafka.h#L3079 This addresses part of #10
whuang1202
pushed a commit
that referenced
this pull request
Aug 10, 2022
…; deduplicating config; cache producers (#12) I believe a nullary call to poll uses a default timeout of -1 (wait indefinitely), but we really just want to make sure that pending callbacks are triggered for the acks that have been buffered in the background, from previous events. poll(0) will not block if the buffer is empty. For testing we need to call flush(-1), so add sync=True as an option. Documentation for `rd_kafka_poll`: https://github.com/edenhill/librdkafka/blob/4faeb8132521da70b6bcde14423a14eb7ed5c55e/src/rdkafka.h#L3079 This addresses part of #10 Configuration is put in config.py rather than inside the send to event bus function so it can be more widely used, do note that setting names are changed to have the EVENT_BUS_KAFKA prefix for use. Caching implemented on producers so data is not lost (one test breaks as a result).
whuang1202
pushed a commit
that referenced
this pull request
Aug 10, 2022
…ache producers (#12) I believe a nullary call to poll uses a default timeout of -1 (wait indefinitely), but we really just want to make sure that pending callbacks are triggered for the acks that have been buffered in the background, from previous events. poll(0) will not block if the buffer is empty. For testing we need to call flush(-1), so add sync=True as an option. Documentation for `rd_kafka_poll`: https://github.com/edenhill/librdkafka/blob/4faeb8132521da70b6bcde14423a14eb7ed5c55e/src/rdkafka.h#L3079 This addresses part of #10 Configuration is put in config.py rather than inside the send to event bus function so it can be more widely used, do note that setting names are changed to have the EVENT_BUS_KAFKA prefix for use. Caching implemented on producers so data is not lost (one test breaks as a result).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe a nullary call to poll uses a default timeout of -1 (wait
indefinitely), but we really just want to make sure that pending callbacks
are triggered for the acks that have been buffered in the background, from
previous events. poll(0) will not block if the buffer is empty.
For testing we need to call flush(-1), so add sync=True as an option.
Documentation for
rd_kafka_poll:https://github.com/edenhill/librdkafka/blob/4faeb8132521da70b6bcde14423a14eb7ed5c55e/src/rdkafka.h#L3079
This addresses part of #10