Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explicitly deserialize messages in event consumer #157

Merged
merged 12 commits into from
May 5, 2023

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented May 4, 2023

Manually deserialize messages from a Consumer instead of using the DeserializingConsumer. This is in service of eventually being able to consume events of multiple types from the same object. Left as Unreleased because it is just the first PR of a series to add the full feature.

Issue: openedx/openedx-events#78

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • Noted any: Concerns, dependencies, deadlines, tickets, testing instructions

@rgraber rgraber changed the title Manually deserialize messages from a Consumer instead of using the DeserializingConsumer. This is in service of eventually being able to consume events of multiple types from the same object. Left as Unreleased because it is just the first PR of a series to add the full feature. refactor: explicitly deserialize messages in event consumer May 4, 2023
edx_event_bus_kafka/internal/consumer.py Outdated Show resolved Hide resolved
edx_event_bus_kafka/internal/consumer.py Outdated Show resolved Hide resolved
edx_event_bus_kafka/internal/consumer.py Outdated Show resolved Hide resolved
edx_event_bus_kafka/internal/tests/test_consumer.py Outdated Show resolved Hide resolved
edx_event_bus_kafka/internal/tests/test_consumer.py Outdated Show resolved Hide resolved
@rgraber rgraber requested a review from timmc-edx May 5, 2023 13:14
@rgraber rgraber merged commit 6712aa7 into main May 5, 2023
@rgraber rgraber deleted the rsgraber/20230504-refactor-consumer branch May 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants