Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use topic record name strategy #172

Merged
merged 7 commits into from
May 17, 2023

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented May 17, 2023

Update serializers to allow multiple event types per topic. See https://docs.openedx.org/projects/event-bus-kafka/en/latest/decisions/0011_multiple_event_types_per_topic.html for the full explanation of why.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • Noted any: Concerns, dependencies, deadlines, tickets, testing instructions

Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get test coverage that proves this was added and would break if this were removed?

Rebecca Graber added 2 commits May 17, 2023 12:36
…h://github.com/openedx/event-bus-kafka into rsgraber/20230508-use-topic-record-name-strategy
@rgraber rgraber merged commit 1c0b149 into main May 17, 2023
@rgraber rgraber deleted the rsgraber/20230508-use-topic-record-name-strategy branch May 17, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants